Thread (17 messages) 17 messages, 4 authors, 2021-12-28

Re: [PATCH 1/3] tty: serial: meson: modify request_irq and free_irq

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-12-21 07:30:28
Also in: linux-amlogic, linux-serial, lkml

On Tue, Dec 21, 2021 at 03:16:32PM +0800, Yu Tu wrote:
Change request_irq to devm_request_irq and free_irq to devm_free_irq.
It's better to change the code this way.
Why?  What did this fix up?  You still are manually requesting and
freeing the irq.  What bug did you fix?
The IRQF_SHARED interrupt flag was added because an interrupt error was
detected when the serial port was opened twice in a row on the project.
That is a different change.  Make that a different patch.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help