Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver
From: Marc Zyngier <maz@kernel.org>
Date: 2021-12-16 08:51:56
Also in:
linux-clk, linux-devicetree, lkml
On Thu, 16 Dec 2021 07:08:10 +0000, Qin Jian [off-list ref] wrote:
Add interrupt controller driver for Sunplus SP7021 SoC. This is the interrupt controller in P-chip which collects all interrupt sources in P-chip and routes them to parent interrupt controller in C-chip. Signed-off-by: Qin Jian <qinjian@cqplus1.com> --- Fix the comments from Marc.
No, you didn't.
+void sp_intc_set_ext(u32 hwirq, int ext_num)
+{
+ sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
+}
+EXPORT_SYMBOL_GPL(sp_intc_set_ext);I already commented on this. In case it wasn't clear, this is a strong NAK to random low-level hacks like this. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel