Thread (3 messages) flat view 3 messages, 2 authors, 2021-12-15

RE: [PATCH] phy: freescale: pcie: explictly add bitfield.h

From: Hongxing Zhu <hongxing.zhu@nxp.com>
Date: 2021-12-15 06:29:30
Also in: linux-phy, lkml

-----Original Message-----
From: Vinod Koul <vkoul@kernel.org>
Sent: Wednesday, December 15, 2021 2:09 PM
To: Kishon Vijay Abraham I <redacted>; Hongxing Zhu
[off-list ref]
Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
kernel test robot [off-list ref]
Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h

kernel test robot complains about missing FIELD_PREP, so include
bitfield.h for that

drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
declaration of function 'FIELD_PREP'
[-Werror=implicit-function-declaration]
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
declaration of function 'FIELD_PREP'
[-Werror=implicit-function-declaration]

Reported-by: kernel test robot <redacted>
Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
standalone phy driver")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks a lot for your help to fix it.
And I'm sorry about that I didn't capture this error in my local build and tests.

Best Regards
Richard Zhu
quoted hunk ↗ jump to hunk
---
 drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index f6502463d49a..04b1aafb29f4 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -3,6 +3,7 @@
  * Copyright 2021 NXP
  */

+#include <linux/bitfield.h>
 #include <linux/clk.h>
 #include <linux/io.h>
 #include <linux/iopoll.h>
--
2.31.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help