Re: [PATCH v1 1/2] mmc: meson-mx-sdhc: Set MANUAL_STOP for multi-block SDIO commands
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: 2021-12-14 18:35:52
Also in:
linux-amlogic, linux-mmc, lkml
Hi Ulf, On Tue, Dec 14, 2021 at 2:21 PM Ulf Hansson [off-list ref] wrote: [...]
quoted
+Maybe add a comment to explain a bit about this workaround here?
sure, I'll add a paragraph for v2 because this workaround/fix is not obvious
quoted
+ manual_stop = cmd->data->blocks > 1 && + (cmd->opcode == SD_IO_RW_DIRECT ||SD_IO_RW_DIRECT doesn't have cmd->data, so checking for that command doesn't make sense.
This also means that you found a bug in the vendor driver :-) I'll drop SD_IO_RW_DIRECT, do another round of testing and then send an updated version. Thank you for taking a closer look! Best regards, Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel