Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop.
From: Mark Yacoub <hidden>
Date: 2021-12-14 15:13:15
Also in:
dri-devel, linux-mediatek, lkml
Hey CK, can we have this merged? Thank you! On Mon, Oct 25, 2021 at 9:13 PM Sean Paul [off-list ref] wrote:
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:quoted
From: Mark Yacoub <redacted> [Why] Creating the prop uses UNKNOWN as the initial value, which is not a supported value if the props is to be supported. [How] Set the panel orientation default value to NORMAL right after creating the prop.Reviewed-by: Sean Paul <redacted>quoted
Tested on Jacuzzi(MTK) Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} Signed-off-by: Mark Yacoub <redacted> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 0ad7157660afa..b7c2528a8f41c 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c@@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) DRM_ERROR("Unable to init panel orientation\n"); goto err_cleanup_encoder; } + drm_connector_set_panel_orientation(dsi->connector, + DRM_MODE_PANEL_ORIENTATION_NORMAL); drm_connector_attach_encoder(dsi->connector, &dsi->encoder); --2.33.0.1079.g6e70778dc9-goog-- Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel