On Wed, Dec 8, 2021 at 7:16 PM Chun-Kuang Hu [off-list ref] wrote:

Hi Mark:

Mark Yacoub [off-list ref] 於 2021年10月28日 週四 上午12:28寫道：

quoted

From: Mark Yacoub <redacted>

At the reset hook, call __drm_atomic_helper_plane_reset which is
called at the initialization of the plane and sets the default value of
rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.

This patch looks good to me, but please fix this checkpatch warning:

Uploaded a new revision. Thanks!

WARNING: From:/Signed-off-by: email address mismatch: 'From: Mark
Yacoub [off-list ref]' != 'Signed-off-by: Mark Yacoub
[off-list ref]'

total: 0 errors, 1 warnings, 11 lines checked

Regards,
Chun-Kuang.

quoted

Tested on Jacuzzi (MTK).
Resolves IGT@kms_properties@plane-properties-{legacy,atomic}

Signed-off-by: Mark Yacoub <redacted>
---
 drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index e6dcb34d30522..accd26481b9fb 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c

@@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane)
                state = kzalloc(sizeof(*state), GFP_KERNEL);
                if (!state)
                        return;
-               plane->state = &state->base;
        }

+       __drm_atomic_helper_plane_reset(plane, &state->base);
+
        state->base.plane = plane;
        state->pending.format = DRM_FORMAT_RGB565;
 }
--

2.33.0.1079.g6e70778dc9-goog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel