RE: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver
From: qinjian[覃健] <qinjian@cqplus1.com>
Date: 2021-12-08 07:21:35
Also in:
linux-clk, linux-devicetree, lkml
quoted
+void sp_intc_set_ext(u32 hwirq, int ext_num) +{ + sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num); +} +EXPORT_SYMBOL_GPL(sp_intc_set_ext);No way. We don't export random symbols without a good justification, and you didn't give any.
This function called by SP7021 display driver to decide DISPLAY_IRQ routing to which parent irq (EXT_INT0 or EXT_INT1). In previous patches, which defined in DT, parsed & processed @ sp_intc_xlate_of() From your comment, this is a SW decision. So I removed it from DT & intc driver, only export this function to access the related intc reg. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel