Re: [PATCH v6] ARM: dts: aspeed: Adding Facebook Bletchley BMC

On Tue, 7 Dec 2021 at 02:53, Howard Chiu (邱冠睿) [off-list ref] wrote:

Hi Joel

Bletchley platform needs to support fan control.
Since Billy's patch for upstream is still under review, I can't add pwm/tach node into dts or the build would fail.

As you know, I had committed the pwm/tach driver for ast26xx to OpenBMC linux, could I commit the dts to OpenBMC linux instead of upstream for early build?

I'd suggest no, omit those features for now, and you can add them in
once we have a driver. The device tree bindings for the tach/pwm need
some work before they can be approved.

When I asked you to fix the patch, I was referring to the usb-c
warnings that I posted about the other week.

Howard

quoted

-----Original Message-----
From: Joel Stanley <joel@jms.id.au>
Sent: Tuesday, December 7, 2021 6:52 AM
To: Patrick Williams <redacted>
Cc: Howard Chiu <redacted>; Arnd Bergmann
[off-list ref]; Olof Johansson [off-list ref]; SoC Team
[off-list ref]; Rob Herring [off-list ref]; Andrew Jeffery
[off-list ref]; Linux ARM [off-list ref];
devicetree [off-list ref]; Linux Kernel Mailing List
[off-list ref]; linux-aspeed [off-list ref];
Howard Chiu (邱冠睿) [off-list ref]
Subject: Re: [PATCH v6] ARM: dts: aspeed: Adding Facebook Bletchley BMC

On Mon, 6 Dec 2021 at 21:25, Patrick Williams [off-list ref] wrote:

quoted

On Wed, Dec 01, 2021 at 11:37:38AM +0800, Howard Chiu wrote:

quoted

Initial introduction of Facebook Bletchley equipped with
Aspeed 2600 BMC SoC.

Signed-off-by: Howard Chiu <redacted>

...

quoted

Change since v2:
- Remove uart5 workaround
- Remove gpio nodes of pca9552/pca9539
- Modify gpio-line-name of led/power/presence pins with openbmc

pattern

quoted

A number of the GPIOs do not have defined openbmc patterns for them yet.

The

quoted

names you have chosen are ok for now, but we will be changing them as we

refine

quoted

development of this machine further.

quoted

+             gpio-line-names =
+

"SLED0_MS_DETECT1","SLED0_VBUS_BMC_EN","SLED0_INA230_ALERT","SLE
D0_P12V_STBY_ALERT",

quoted

quoted

+

"SLED0_SSD_ALERT","SLED0_MS_DETECT0","SLED0_RST_CCG5","SLED0_FUSB
302_INT",

quoted

quoted

+

"SLED0_MD_STBY_RESET","SLED0_MD_IOEXP_EN_FAULT","SLED0_MD_DIR","
SLED0_MD_DECAY",

quoted

quoted

+

"SLED0_MD_MODE1","SLED0_MD_MODE2","SLED0_MD_MODE3","power-ho
st0";

quoted

Such as these...

quoted

--
2.25.1

Otherwise,

Reviewed-by: Patrick Williams <redacted>

Thanks for reviewing.

Howard, I'm merging patches for v5.17 but I can't apply this until you
fix the warnings I mentioned.

Cheers,

Jeol

quoted

--
Patrick Williams

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel