Thread (4 messages) 4 messages, 3 authors, 2022-01-04

Re: [PATCH] drm/stm: remove conflicting framebuffers

From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2021-12-06 14:23:46
Also in: dri-devel, lkml

Hi

Am 06.12.21 um 14:47 schrieb Yannick Fertre:
In case of using simplefb or another conflicting framebuffer,
call drm_aperture_remove_framebuffers() to remove memory allocated.

Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com>
The patch should have contained a note that this is version 2 of the 
change with a short changelog. Anyway

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Best regards
Thomas
quoted hunk ↗ jump to hunk
---
  drivers/gpu/drm/stm/drv.c | 5 +++++
  1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
index 222869b232ae..9f441aadf2d5 100644
--- a/drivers/gpu/drm/stm/drv.c
+++ b/drivers/gpu/drm/stm/drv.c
@@ -14,6 +14,7 @@
  #include <linux/of_platform.h>
  #include <linux/pm_runtime.h>
  
+#include <drm/drm_aperture.h>
  #include <drm/drm_atomic.h>
  #include <drm/drm_atomic_helper.h>
  #include <drm/drm_drv.h>
@@ -183,6 +184,10 @@ static int stm_drm_platform_probe(struct platform_device *pdev)
  
  	DRM_DEBUG("%s\n", __func__);
  
+	ret = drm_aperture_remove_framebuffers(false, &drv_driver);
+	if (ret)
+		return ret;
+
  	dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
  
  	ddev = drm_dev_alloc(&drv_driver, dev);
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help