On Mon, Dec 6, 2021 at 7:07 AM Andreas Kemnade [off-list ref] wrote:

On Thu,  2 Dec 2021 22:07:58 +1000
Alistair Francis [off-list ref] wrote:

quoted

Connect the dispaly on the reMarkable2.

Signed-off-by: Alistair Francis <redacted>
---
 arch/arm/boot/dts/imx7d-remarkable2.dts | 73 +++++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts
index b66d28b30d75..bb0c68d24583 100644
--- a/arch/arm/boot/dts/imx7d-remarkable2.dts
+++ b/arch/arm/boot/dts/imx7d-remarkable2.dts

[...]

quoted

@@ -187,6 +221,45 @@ MX7D_PAD_I2C4_SCL__I2C4_SCL              0x4000007f
              >;
      };

+     pinctrl_lcdif: lcdifgrp {
+             fsl,pins = <
+                     MX7D_PAD_LCD_DATA00__LCD_DATA0          0x79
+                     MX7D_PAD_LCD_DATA01__LCD_DATA1          0x79
+                     MX7D_PAD_LCD_DATA02__LCD_DATA2          0x79
+                     MX7D_PAD_LCD_DATA03__LCD_DATA3          0x79
+                     MX7D_PAD_LCD_DATA04__LCD_DATA4          0x79
+                     MX7D_PAD_LCD_DATA05__LCD_DATA5          0x79
+                     MX7D_PAD_LCD_DATA06__LCD_DATA6          0x79
+                     MX7D_PAD_LCD_DATA07__LCD_DATA7          0x79
+                     MX7D_PAD_LCD_DATA08__LCD_DATA8          0x79
+                     MX7D_PAD_LCD_DATA09__LCD_DATA9          0x79
+                     MX7D_PAD_LCD_DATA10__LCD_DATA10         0x79
+                     MX7D_PAD_LCD_DATA11__LCD_DATA11         0x79
+                     MX7D_PAD_LCD_DATA12__LCD_DATA12         0x79
+                     MX7D_PAD_LCD_DATA13__LCD_DATA13         0x79
+                     MX7D_PAD_LCD_DATA14__LCD_DATA14         0x79
+                     MX7D_PAD_LCD_DATA15__LCD_DATA15         0x79
+
+                     MX7D_PAD_LCD_DATA17__LCD_DATA17         0x79
+                     MX7D_PAD_LCD_DATA18__LCD_DATA18         0x79
+                     MX7D_PAD_LCD_DATA19__LCD_DATA19         0x79
+                     MX7D_PAD_LCD_DATA20__LCD_DATA20         0x79
+                     MX7D_PAD_LCD_DATA21__LCD_DATA21         0x79
+
+                     MX7D_PAD_LCD_DATA23__LCD_DATA23         0x79
+                     MX7D_PAD_LCD_CLK__LCD_CLK               0x79
+                     MX7D_PAD_LCD_ENABLE__LCD_ENABLE         0x79
+                     MX7D_PAD_LCD_VSYNC__LCD_VSYNC           0x79
+                     MX7D_PAD_LCD_HSYNC__LCD_HSYNC           0x79
+                     MX7D_PAD_LCD_RESET__LCD_RESET           0x79
+             >;
+     };

shouldn't this belong into the upper list:

quoted

+
+             fsl,pins = <
+                     MX7D_PAD_LCD_DATA22__GPIO3_IO27         0x74
+             >;
+     };
+

probably some rebase or merge accident. If I submit non-trivial things,
I usually apply my patches to a separate git tree and do a final
compile, that might help to reduce some trouble.

Yeah, it was a rebase error. I split these patches out from my working tree.

Alistair

Regards,
Andreas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel