Hello Guangming,

On Mon, 29 Nov 2021 at 23:35, John Stultz [off-list ref] wrote:

On Thu, Nov 25, 2021 at 11:48 PM [off-list ref] wrote:

quoted

From: Guangming <redacted>

For previous version, it uses 'sg_table.nent's to traverse sg_table in pages
free flow.
However, 'sg_table.nents' is reassigned in 'dma_map_sg', it means the number of
created entries in the DMA adderess space.
So, use 'sg_table.nents' in pages free flow will case some pages can't be freed.

Here we should use sg_table.orig_nents to free pages memory, but use the
sgtable helper 'for each_sgtable_sg'(, instead of the previous rather common
helper 'for_each_sg' which maybe cause memory leak) is much better.

Thanks for catching this and the patch; applied to drm-misc-fixes.

quoted

Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order pages if available")
Signed-off-by: Guangming <redacted>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Cc: <redacted> # 5.11.*

Thanks so much for catching this and sending in all the revisions!

Reviewed-by: John Stultz <redacted>

Best,
Sumit.

-- 
Thanks and regards,

Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel