-----Original Message-----
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sent: Tuesday, November 30, 2021 7:47 PM
To: Neal Liu <neal_liu@aspeedtech.com>
Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>; Andrew
Jeffery [off-list ref]; Cai Huoqing [off-list ref]; Tao Ren
[off-list ref]; Julia Lawall [off-list ref]; kernel test
robot [off-list ref]; Sasha Levin [off-list ref];
linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; BMC-SW
[off-list ref]; Benjamin Herrenschmidt
[off-list ref]
Subject: Re: [PATCH v2 3/4] usb: aspeed-vhub: fix ep0 OUT ack received wrong
length issue

On Tue, Nov 30, 2021 at 06:42:55PM +0800, Neal Liu wrote:

quoted

If multiple devices in vhub are enumerated simultaneously, ep0 OUT ack
might received wrong data length. Using expected data length instead.

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
---
 drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c

b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
index 74ea36c19b1e..bea9cbb191a2 100644

--- a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c

@@ -251,6 +251,13 @@ static void ast_vhub_ep0_do_receive(struct

ast_vhub_ep *ep, struct ast_vhub_req

quoted

 		len = remain;
 		rc = -EOVERFLOW;
 	}
+
+	/* HW return wrong data len */

Please spell out "Hardware"?

thanks,

greg k-h

Sure, I'll fix it in next patch.
Thanks

Best Regards,
-Neal



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel