Re: [PATCH v4 04/13] mtd: spi-nor: core: Introduce flash_info mfr_flags
From: <hidden>
Date: 2021-11-23 06:46:11
On 11/22/21 8:34 PM, Michael Walle wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Am 2021-11-22 10:50, schrieb Tudor Ambarus:quoted
Used in the manufacturer fixup hooks to differentiate support between flashes of the same manufacturer. Not used in the SPI NOR core. Signed-off-by: Tudor Ambarus <redacted>Nice! Reviewed-by: Michael Walle <redacted>quoted
@@ -58,28 +61,46 @@ static const struct spi_nor_fixups sst26vf_fixups ={ static const struct flash_info sst_parts[] = { /* SST -- large erase sizes are "overlays", "sectors" are 4K */ { "sst25vf040b", INFO(0xbf258d, 0, 64 * 1024, 8, - SECT_4K | SST_WRITE | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) }, + SECT_4K | SPI_NOR_HAS_LOCK | + SPI_NOR_SWP_IS_VOLATILE) + MFR_FLAGS(SST_WRITE) },Looks a bit odd, but I'm fine with that. Does checkpatch.pl complain, though?
I've run checkpatch --strict for the series, no complaint for things introduced by me. None here. Check patch 5/13 to see how all the flags will look like. Thanks, ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel