Re: [PATCH v8 3/3] mailbox: mediatek: add support for adsp mailbox controller
From: Tzung-Bi Shih <hidden>
Date: 2021-11-30 08:43:21
Also in:
alsa-devel, linux-devicetree, linux-mediatek, lkml
On Mon, Nov 29, 2021 at 06:19:45PM +0800, allen-kh.cheng wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
+static int mtk_adsp_mbox_probe(struct platform_device *pdev)
+{[...]
+ mbox->dev = dev; + mbox->ops = &mtk_adsp_mbox_chan_ops; + mbox->txdone_irq = false; + mbox->txdone_poll = true; + mbox->of_xlate = mtk_adsp_mbox_xlate; + mbox->num_chans = 1; + mbox->chans = devm_kzalloc(mbox->dev, sizeof(*mbox->chans), GFP_KERNEL);
I have commented in the v3[1]. To be neat, I prefer to use "dev" instead of "mbox->dev". If you ever have the chance to respin the series, please fix it. [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20211124084514.28002-3-allen-kh.cheng@mediatek.com/#24614933 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel