Re: [PATCH v3 3/3] firmware: mediatek: add adsp ipc protocol interface
From: Tzung-Bi Shih <hidden>
Date: 2021-11-25 06:31:20
Also in:
alsa-devel, linux-devicetree, linux-mediatek, lkml
On Thu, Nov 25, 2021 at 09:47:22AM +0800, allen-kh.cheng wrote:
On Wed, 2021-11-24 at 18:25 +0800, Tzung-Bi Shih wrote:quoted
On Wed, Nov 24, 2021 at 04:45:14PM +0800, allen-kh.cheng wrote:quoted
+ for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) { + chan_name = kasprintf(GFP_KERNEL, "mbox%d", i); + if (!chan_name) + return -ENOMEM; + + dsp_chan = &dsp_ipc->chans[i]; + cl = &dsp_chan->cl; + cl->dev = dev->parent; + cl->tx_block = false; + cl->knows_txdone = false; + cl->tx_prepare = NULL; + cl->rx_callback = adsp_ipc_recv; + + dsp_chan->ipc = dsp_ipc; + dsp_chan->idx = i; + dsp_chan->ch = mbox_request_channel_byname(cl, chan_name); + if (IS_ERR(dsp_chan->ch)) { + ret = PTR_ERR(dsp_chan->ch); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to request mbox chan %d ret %d\n", + i, ret);If ret == -EPROBE_DEFER, wouldn't it need to return -EPROBE_DEFER? It doesn't retry later if -EPROBE_DEFER.If ret != -EPROBE_DEFER, it will show a error message then goto out. If ret == -EPROBE_DEFER, probe funcation also will goto out. Both of them will return ret. will not go to next round.
I see. I misunderstood. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel