Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()
From: Etienne Carriere <hidden>
Date: 2021-11-23 13:18:11
Also in:
kernel-janitors, lkml
On Tue, 23 Nov 2021 at 09:23, Wei Yongjun [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The driver allocates the mutex but not initialize it. Use mutex_init() on it to initialize it correctly. Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport") Reported-by: Hulk Robot <redacted> Signed-off-by: Wei Yongjun <redacted> --- drivers/firmware/arm_scmi/optee.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c index d9819b0197ec..901737c9f5f8 100644 --- a/drivers/firmware/arm_scmi/optee.c +++ b/drivers/firmware/arm_scmi/optee.c@@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev) agent->dev = dev; agent->tee_ctx = tee_ctx; INIT_LIST_HEAD(&agent->channel_list); + mutex_init(&agent->mu); ret = get_capabilities(agent); if (ret)
`Reviewed-by: Etienne Carriere [off-list ref]` Indeed. Thanks for the fix. Etienne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel