RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec

Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec

quoted

+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_enet>;
+	phy-mode = "rmii";

Is this really a Fast Ethernet? Not 1G?

Not 1G. it only support 10M/100M ethernet.

quoted

+	phy-handle = <&ethphy>;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy: ethernet-phy {
+			reg = <1>;

I'm surprised this does not give warnings from the DTS tools. There is a reg
value, so it should be ethernet-phy@1

I not see warning per my build:
"
*** Default configuration is based on 'defconfig'
#
# No change to .config
#
  CALL    scripts/atomic/check-atomics.sh
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  DTC     arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb
"
Anyway I will check and fix if the node needs a fix.

Thanks,
Peng

  Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel