Re: [PATCH] ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE
From: Takashi Iwai <hidden>
Date: 2021-11-18 07:27:31
Also in:
linux-hardening, lkml
From: Takashi Iwai <hidden>
Date: 2021-11-18 07:27:31
Also in:
linux-hardening, lkml
On Wed, 17 Nov 2021 23:01:50 +0100, Kees Cook wrote:
On Wed, Nov 17, 2021 at 08:32:44PM +0100, Takashi Iwai wrote:quoted
When CONFIG_FORTIFY_SOURCE is set, memcpy() checks the potential buffer overflow and panics. The code in sofcpga bootstrapping contains the memcpy() calls are mistakenly translated as the shorter size, hence it triggers a panic as if it were overflowing. This patch adds the __NO_FORTIFY define for avoiding the false-positive crash. Buglink: https://bugzilla.suse.com/show_bug.cgi?id=1192473 Signed-off-by: Takashi Iwai <redacted> --- I took an easier path for now, as the attempt with a foced cast failed. If there is a better way to handle, let me know, I'd happily resubmit. Thanks!The way these have been fixed in the past is to declare these as char arrays (see include/asm-generic/sections.h). I'd prefer something like this (totally untested):
(snip) That looks better, indeed. I'll rebuild the kernel with it and ask the bug reporter for testing it. Thanks! Takashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel