Thread (13 messages) 13 messages, 5 authors, 2021-11-09

Re: [RFC 3/3] gpiolib: coldfire: remove custom asm/gpio.h

From: Linus Walleij <hidden>
Date: 2021-11-09 20:07:59
Also in: linux-gpio, linux-m68k, linux-sh, lkml

On Fri, Nov 5, 2021 at 2:05 PM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de>

Now that coldfire is the only user of a custom asm/gpio.h, it seems
better to remove this as well, and have the same interface everywhere.

For the gpio_get_value()/gpio_set_value()/gpio_to_irq(), gpio_cansleep()
functions, the custom version is only a micro-optimization to inline the
function for constant GPIO numbers. However, in the coldfire defconfigs,
I was unable to find a single instance where this micro-optimization
was even used, so to my best knowledge removing this has no downsides.

The custom gpio_request_one() function is even less useful, as it is
guarded by an #ifdef that is never true.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help