Re: [PATCH v2 03/12] watchdog: s3c2410: Fail probe if can't find valid timeout
From: Krzysztof Kozlowski <hidden>
Date: 2021-11-02 09:49:29
Also in:
linux-devicetree, linux-samsung-soc, linux-watchdog, lkml
On 31/10/2021 13:22, Sam Protsenko wrote:
Driver can't work properly if there no valid timeout was found in s3c2410wdt_set_heartbeat(). Ideally, that function should be reworked in a way that it's always able to find some valid timeout. As a temporary solution let's for now just fail the driver probe in case the valid timeout can't be found in s3c2410wdt_set_heartbeat() function. Reported-by: Guenter Roeck <linux@roeck-us.net> Suggested-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- Changes in v2: - (none): it's a new patch drivers/watchdog/s3c2410_wdt.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)
Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel