Thread (12 messages) 12 messages, 2 authors, 2021-11-17

Re: [PATCH v1 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator

From: Leo Yan <hidden>
Date: 2021-11-01 10:59:45
Also in: lkml

Hi Suzuki,

On Mon, Nov 01, 2021 at 09:49:06AM +0000, Suzuki Kuruppassery Poulose wrote:
Hi Leo

On 31/10/2021 14:42, Leo Yan wrote:
quoted
When read the virtual context ID comparator value via sysfs node, the
driver firstly reads out the index, then reads the comparator value
based on index. >
This patch adds the spinlock to protect the atomicity for up two steps.
minor nit: This could be :

"Updates to the values and the index are protected via the
spinlock. Ensure we use the same lock to read the value
safely"
Yeah, this is more simple and clear.  Will use it.
With that:

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Thanks for review.

Leo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help