Re: [PATCH] hwrng: mediatek - Force runtime pm ops for sleep ops
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-10-08 12:24:28
Also in:
linux-crypto, linux-mediatek
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-10-08 12:24:28
Also in:
linux-crypto, linux-mediatek
On Thu, Sep 30, 2021 at 09:12:42PM +0200, Markus Schneider-Pargmann wrote:
Currently mtk_rng_runtime_suspend/resume is called for both runtime pm and system sleep operations. This is wrong as these should only be runtime ops as the name already suggests. Currently freezing the system will lead to a call to mtk_rng_runtime_suspend even if the device currently isn't active. This leads to a clock warning because it is disabled/unprepared although it isn't enabled/prepared currently. This patch fixes this by only setting the runtime pm ops and forces to call the runtime pm ops from the system sleep ops as well if active but not otherwise. Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> --- drivers/char/hw_random/mtk-rng.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel