Re: [PATCH v2] hwrng: meson - Improve error handling for core clock
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-10-01 06:44:09
Also in:
linux-amlogic, linux-crypto
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-10-01 06:44:09
Also in:
linux-amlogic, linux-crypto
On Mon, Sep 20, 2021 at 09:44:05AM +0200, Uwe Kleine-König wrote:
-ENOENT (ie. "there is no clock") is fine to ignore for an optional clock, other values are not supposed to be ignored and should be escalated to the caller (e.g. -EPROBE_DEFER). Ignore -ENOENT by using devm_clk_get_optional(). While touching this code also add an error message for the fatal errors. Signed-off-by: Uwe Kleine-König <redacted> --- Hello, compared to (implicit) v1 (https://lore.kernel.org/r/20210914142428.57099-1-u.kleine-koenig@pengutronix.de (local)) this used dev_err_probe() as suggested by Martin Blumenstingl. v1 got a "Reviewed-by: Neil Armstrong [off-list ref]", I didn't add that because of the above change. (Hmm, my setup is broken, the b4 patch signature was done before I added this message. I wonder if this will break the signature ...) Best regards Uwe drivers/char/hw_random/meson-rng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel