-----Original Message-----
From: Francesco Dolcini <redacted>
Sent: Tuesday, October 26, 2021 4:52 PM
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Mark Brown <broonie@kernel.org>; Francesco Dolcini
[off-list ref]; l.stach@pengutronix.de;
bhelgaas@google.com; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com;
linux-pci@vger.kernel.org; dl-linux-imx [off-list ref];
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
kernel@pengutronix.de
Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never
came up

On Tue, Oct 26, 2021 at 02:18:18AM +0000, Richard Zhu wrote:

quoted

The _enabled check is used because that this regulator is optional in the HW

design.

quoted

To make the codes clean and aligned on different HW boards, the _enabled

check is added.

quoted

The root cause is that the error return is not handled properly by the

controller driver.

quoted

I.MX PCIe controller doesn't support the Hot-Plug, and it would return
-110 error when PCIe link never came up. Thus, the _probe would be failed

in the end.

quoted

The clocks/regulator usage balance should be considered by i.MX PCIe

controller, that's all.

quoted

It's not a general case, and the problem is not caused by the regulator

support.

Hello Richard,
I have one curiosity on this topic. Does this works well in case the regulator is
shared? I just want to be sure that if the regulator is shared everything is
working fine even if the PCI-E link is not used or not coming up for any reason.

[Richard Zhu] Hi Francesco:
Actually, this regulator used by i.MX PCIe controller driver is one fixed gpio regulator.
Refer to my understand, this regulator is not shared by different devices.

Up to now, it works fine to power up the PCIe slot populated on the HW board.

BR
Richard

Francesco

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel