On Mon, Oct 25, 2021 at 11:53:17AM +0000, Abhyuday Godhasara wrote:

Hi Greg,

quoted

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
Sent: Monday, October 25, 2021 2:05 PM
To: Abhyuday Godhasara <redacted>
Cc: Michal Simek <redacted>; Rajan Vaja <redacted>;
Manish Narani [off-list ref]; zou_wei@huawei.com; Sai Krishna
Potthuri [off-list ref]; Jiaying Liang [off-list ref]; Jiaying Liang
[off-list ref]; linux-kernel@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; Tejas Patel [off-list ref]
Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp
firmware

On Mon, Oct 25, 2021 at 01:23:45AM -0700, Abhyuday Godhasara wrote:

quoted

In zynqmp-firmware, register notifier is not supported, add support of
register notifier in zynqmp-firmware.

Signed-off-by: Tejas Patel <redacted>
Signed-off-by: Abhyuday Godhasara <redacted>
Acked-by: Michal Simek <redacted>
---
Changes in v6:
- Minor fix

That is vague, what got "fixed" here?

[Abhyuday] During rebase of patches on your tree couple of lines code was get mixed unintendedly in xlnx-zynqmp.h header file due to use of "git am -3".
I corrected the below code which was wrong in previous patch v5.
+static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
+					      const u32 wake, const u32 enable) {
+	return -ENODEV;
+}

In v5 it was like below, which is wrong
static inline int zynqmp_pm_load_pdi(const u32 src, const u64 address)
static inline int zynqmp_pm_register_notifier(const u32 node, const u32 event,
					      const u32 wake, const u32 enable) {
	return -ENODEV;
}
So, the body was missing here for zynqmp_pm_load_pdi in v5.

And why did you not describe this in the changelog text?  That is what I
was asking about here.  Please be specific, as reviewers need to know
this type of thing.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel