From: Mark Yacoub <hidden> Date: 2021-10-22 17:24:23
From: Mark Yacoub <redacted>
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the props is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop.
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
From: Sean Paul <sean@poorly.run> Date: 2021-10-26 01:13:24
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:
From: Mark Yacoub <redacted>
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the props is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop.
Reviewed-by: Sean Paul <redacted>
quoted hunk
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
From: Mark Yacoub <hidden> Date: 2021-12-14 15:13:15
Hey CK, can we have this merged?
Thank you!
On Mon, Oct 25, 2021 at 9:13 PM Sean Paul [off-list ref] wrote:
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:
quoted
From: Mark Yacoub <redacted>
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the props is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop.
Reviewed-by: Sean Paul <redacted>
quoted
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
From: Chun-Kuang Hu <chunkuang.hu@kernel.org> Date: 2021-12-15 16:14:58
Hi, Mark:
Mark Yacoub [off-list ref] 於 2021年12月14日 週二 下午11:13寫道：
Hey CK, can we have this merged?
Thank you!
On Mon, Oct 25, 2021 at 9:13 PM Sean Paul [off-list ref] wrote:
quoted
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:
quoted
From: Mark Yacoub <redacted>
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the props is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop.
Reviewed-by: Sean Paul <redacted>
quoted
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
From: Mark Yacoub <hidden> Date: 2021-12-15 17:27:21
On Wed, Dec 15, 2021 at 11:14 AM Chun-Kuang Hu [off-list ref] wrote:
Hi, Mark:
Mark Yacoub [off-list ref] 於 2021年12月14日 週二 下午11:13寫道：
quoted
Hey CK, can we have this merged?
Thank you!
On Mon, Oct 25, 2021 at 9:13 PM Sean Paul [off-list ref] wrote:
quoted
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:
quoted
From: Mark Yacoub <redacted>
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the props is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop.
Reviewed-by: Sean Paul <redacted>
quoted
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
@@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)DRM_ERROR("Unable to init panel orientation\n");gotoerr_cleanup_encoder;}+drm_connector_set_panel_orientation(dsi->connector,+DRM_MODE_PANEL_ORIENTATION_NORMAL);
In drm_connector_set_panel_orientation() [1], I find that the
orientation could be set only once. Once you set it to normal, it
could not be set to other orientation. Right?
From: Chun-Kuang Hu <chunkuang.hu@kernel.org> Date: 2021-12-16 16:53:49
Hi, Mark:
Mark Yacoub [off-list ref] 於 2021年12月16日 週四 上午1:25寫道：
On Wed, Dec 15, 2021 at 11:14 AM Chun-Kuang Hu [off-list ref] wrote:
quoted
Hi, Mark:
Mark Yacoub [off-list ref] 於 2021年12月14日 週二 下午11:13寫道：
quoted
Hey CK, can we have this merged?
Thank you!
On Mon, Oct 25, 2021 at 9:13 PM Sean Paul [off-list ref] wrote:
quoted
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:
quoted
From: Mark Yacoub <redacted>
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the props is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop.
Reviewed-by: Sean Paul <redacted>
quoted
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
@@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)DRM_ERROR("Unable to init panel orientation\n");gotoerr_cleanup_encoder;}+drm_connector_set_panel_orientation(dsi->connector,+DRM_MODE_PANEL_ORIENTATION_NORMAL);
In drm_connector_set_panel_orientation() [1], I find that the
orientation could be set only once. Once you set it to normal, it
could not be set to other orientation. Right?
From: Mark Yacoub <hidden> Date: 2021-12-16 18:29:34
This makes sense. Thanks for pointing that out I wasn't aware of it.
I'll take a closer look and try to come up with something better.
Thanks Chun-Kuang!
On Thu, Dec 16, 2021 at 11:53 AM Chun-Kuang Hu [off-list ref] wrote:
Hi, Mark:
Mark Yacoub [off-list ref] 於 2021年12月16日 週四 上午1:25寫道：
quoted
On Wed, Dec 15, 2021 at 11:14 AM Chun-Kuang Hu [off-list ref] wrote:
quoted
Hi, Mark:
Mark Yacoub [off-list ref] 於 2021年12月14日 週二 下午11:13寫道：
quoted
Hey CK, can we have this merged?
Thank you!
On Mon, Oct 25, 2021 at 9:13 PM Sean Paul [off-list ref] wrote:
quoted
On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote:
quoted
From: Mark Yacoub <redacted>
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the props is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop.
Reviewed-by: Sean Paul <redacted>
quoted
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
1 file changed, 2 insertions(+)
@@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)DRM_ERROR("Unable to init panel orientation\n");gotoerr_cleanup_encoder;}+drm_connector_set_panel_orientation(dsi->connector,+DRM_MODE_PANEL_ORIENTATION_NORMAL);
In drm_connector_set_panel_orientation() [1], I find that the
orientation could be set only once. Once you set it to normal, it
could not be set to other orientation. Right?
From: Mark Yacoub <hidden> Date: 2021-12-29 18:41:39
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the prop is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop if no DSI panel exists.
Panels have their own orientations, and panel orientation can't be
overriden once initialized to a value.
v1:
Set panel orientation only if DSI panel does not exist.
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
1 file changed, 7 insertions(+)
@@ -1040,6 +1040,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)gotoerr_cleanup_encoder;}+// A drm_panel can have its own orientation. If there is no panel, set the+// orientation to NORMAL.+if(!dsi->panel){+drm_connector_set_panel_orientation(+dsi->connector,DRM_MODE_PANEL_ORIENTATION_NORMAL);+}+drm_connector_attach_encoder(dsi->connector,&dsi->encoder);return0;
--
2.34.1.448.ga2b2bfdf31-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Mark Yacoub <hidden> Date: 2021-12-29 18:44:26
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the prop is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop if no DSI panel exists.
Panels have their own orientations, and panel orientation can't be
overriden once initialized to a value.
v1:
Set panel orientation only if DSI panel does not exist.
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
1 file changed, 7 insertions(+)
@@ -1040,6 +1040,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)gotoerr_cleanup_encoder;}+/* A drm_panel can have its own orientation. If there is no panel, set the+*orientationtoNORMAL.*/+if(!dsi->panel){+drm_connector_set_panel_orientation(+dsi->connector,DRM_MODE_PANEL_ORIENTATION_NORMAL);+}+drm_connector_attach_encoder(dsi->connector,&dsi->encoder);return0;
--
2.34.1.448.ga2b2bfdf31-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Chun-Kuang Hu <chunkuang.hu@kernel.org> Date: 2022-01-03 12:39:37
Hi, Mark:
Mark Yacoub [off-list ref] 於 2021年12月30日 週四 上午2:44寫道：
quoted hunk
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the prop is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop if no DSI panel exists.
Panels have their own orientations, and panel orientation can't be
overriden once initialized to a value.
v1:
Set panel orientation only if DSI panel does not exist.
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
1 file changed, 7 insertions(+)
@@ -1040,6 +1040,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)gotoerr_cleanup_encoder;}+/* A drm_panel can have its own orientation. If there is no panel, set the+*orientationtoNORMAL.*/+if(!dsi->panel){
Please send patch based on latest kernel version. In latest kernel
version, struct mtk_dsi{} has no member 'panel'.
Regards,
Chun-Kuang.
From: Mark Yacoub <hidden> Date: 2022-01-05 21:23:46
[Why]
Creating the prop uses UNKNOWN as the initial value, which is not a
supported value if the prop is to be supported.
[How]
Set the panel orientation default value to NORMAL right after creating
the prop if no DSI panel exists.
Panels have their own orientations, and panel orientation can't be
overriden once initialized to a value.
v2:
Move to the latest code where struct mtk_dsi{} has no member 'panel'.
v1:
Set panel orientation only if DSI panel does not exist.
Tested on Jacuzzi(MTK)
Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic}
Signed-off-by: Mark Yacoub <redacted>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
@@ -967,6 +969,15 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)}drm_connector_attach_encoder(dsi->connector,&dsi->encoder);+ret=drm_of_find_panel_or_bridge(dev->of_node,0,0,&panel,+&dsi->next_bridge);+/* A drm_panel can have its own orientation. If there is no panel, set the+*orientationtoNORMAL.*/+if(ret||!panel){+drm_connector_set_panel_orientation(+dsi->connector,DRM_MODE_PANEL_ORIENTATION_NORMAL);+}+return0;err_cleanup_encoder: