Re: [PATCH v3 2/2] ACPI: APEI: Filter the PCI MCFG address with an arch-agnostic method
From: Xuesong Chen <hidden>
Date: 2021-10-20 02:35:40
Also in:
linux-acpi, linux-pci, lkml
On 19/10/2021 23:04, Bjorn Helgaas wrote:
On Tue, Oct 19, 2021 at 12:50:33PM +0800, Xuesong Chen wrote:quoted
The commit d91525eb8ee6 ("ACPI, EINJ: Enhance error injection tolerance level") fixes the issue that the ACPI/APEI can not access the PCI MCFG address on x86 platform, but this issue can also happen on other architectures, for instance, we got below error message on arm64 platform: ... APEI: Can not request [mem 0x50100000-0x50100003] for APEI EINJ Trigger registers ... This patch will try to handle this case in a more common way instead of the original 'arch' specific solution, which will be beneficial to all the APEI-dependent platforms after that. Signed-off-by: Xuesong Chen <redacted> Reported-by: kernel test robot <redacted>The purpose of this patch is not to fix a problem reported by the kernel test robot, so remove this tag.
Yes, will do
I know the robot found a problem with a previous version of this patch, but we treat that the same as a code review comment. We normally don't explicitly credit reviewers unless it was something major, and then it would go in the commit log, not a "Reported-by" tag. It makes sense to credit the kernel test robot for things found in Linus' tree, but it's a little too aggressive about suggesting the tag for problems with unmerged changes.quoted
Reviewed-by: Lorenzo Pieralisi <redacted>This tag can only be added when Lorenzo explicitly supplies it himself. I do not see that on the mailing list, so please remove this tag as well. After Lorenzo supplies it, you can include it in future postings as long as you don't make significant changes to the patch.
En, Lorenzo does have comments on the patch#2 and I also update that patch according to his feedback, so why the tag is here. OK, I'll add this tag if Lorenzo can supply it explicitly before I send the next version.
Bjorn
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel