Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: 2021-10-16 18:05:37
Also in:
linux-hardening, lkml
On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote:
On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote:quoted
sizeof when applied to a pointer typed expression gives the size of the pointer. ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer This issue was detected with the help of Coccinelle. Reported-by: Zeal Robot <redacted> Signed-off-by: jing yangyang <redacted>quoted
From looking at the git history, we should add:Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)" With that: Acked-by: Mark Rutland [off-list ref] Lorenzo, how do we normally direct these patches?
It seems that these patches are consistently being ignored[1][2][3]. So, I'll take this in my -next tree[4] before it gets lost again. Thanks -- Gustavo [1] https://lore.kernel.org/lkml/20200917081353.2083241-1-liushixin2@huawei.com/ (local) [2] https://lore.kernel.org/lkml/1606179525-63938-1-git-send-email-tiantao6@hisilicon.com/ (local) [3] https://lore.kernel.org/lkml/20211012024229.180058-1-davidcomponentone@gmail.com/ (local) [4] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp-misc-fixes
quoted
--- drivers/firmware/psci/psci_checker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c index 9a369a2..116eb46 100644 --- a/drivers/firmware/psci/psci_checker.c +++ b/drivers/firmware/psci/psci_checker.c@@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups) if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) return -ENOMEM; - cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups), + cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups), GFP_KERNEL); if (!cpu_groups) { free_cpumask_var(tmp);-- 1.8.3.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel