Re: [PATCH 3/5] cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure
From: Lukasz Luba <lukasz.luba@arm.com>
Date: 2021-10-15 12:13:54
Also in:
linux-arm-msm, linux-pm, lkml
From: Lukasz Luba <lukasz.luba@arm.com>
Date: 2021-10-15 12:13:54
Also in:
linux-arm-msm, linux-pm, lkml
On 10/11/21 10:17 PM, Thara Gopinath wrote:
On 10/7/21 4:07 AM, Lukasz Luba wrote:quoted
The thermal pressure signal gives information to the scheduler about reduced CPU capacity due to thermal. It is based on a value stored in a per-cpu 'thermal_pressure' variable. The online CPUs will get the new value there, while the offline won't. Unfortunately, when the CPU is back online, the value read from per-cpu variable might be wrong (stale data). This might affect the scheduler decisions, since it sees the CPU capacity differently than what is actually available. Fix it by making sure that all online+offline CPUs would get the proper value in their per-cpu variable when there is throttling or throttling is removed. Fixes: 275157b367f479 ("cpufreq: qcom-cpufreq-hw: Add dcvs interrupt support") Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>Thanks for the fix. Reviewed-by: Thara Gopinath <redacted>
Thank you for the review! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel