Re: [PATCH 3/4] dmaengine: at_xdmac: use __maybe_unused for pm functions
From: <hidden>
Date: 2021-10-15 08:03:39
Also in:
dmaengine, lkml
On 10/7/21 2:12 PM, Claudiu Beznea wrote:
Use __maybe_unused for pm functions.
Explaining why would be nice. E.g. avoiding ifdefs throughout the code, and stop defining atmel_xdmac_prepare as NULL.
Signed-off-by: Claudiu Beznea <redacted>
Reviewed-by: Tudor Ambarus <redacted>
quoted hunk ↗ jump to hunk
--- drivers/dma/at_xdmac.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index e18abbd56fb5..12371396fcc0 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c@@ -1950,8 +1950,7 @@ static void at_xdmac_axi_config(struct platform_device *pdev) } } -#ifdef CONFIG_PM -static int atmel_xdmac_prepare(struct device *dev) +static int __maybe_unused atmel_xdmac_prepare(struct device *dev) { struct at_xdmac *atxdmac = dev_get_drvdata(dev); struct dma_chan *chan, *_chan;@@ -1965,12 +1964,8 @@ static int atmel_xdmac_prepare(struct device *dev) } return 0; } -#else -# define atmel_xdmac_prepare NULL -#endif -#ifdef CONFIG_PM_SLEEP -static int atmel_xdmac_suspend(struct device *dev) +static int __maybe_unused atmel_xdmac_suspend(struct device *dev) { struct at_xdmac *atxdmac = dev_get_drvdata(dev); struct dma_chan *chan, *_chan;@@ -1994,7 +1989,7 @@ static int atmel_xdmac_suspend(struct device *dev) return 0; } -static int atmel_xdmac_resume(struct device *dev) +static int __maybe_unused atmel_xdmac_resume(struct device *dev) { struct at_xdmac *atxdmac = dev_get_drvdata(dev); struct at_xdmac_chan *atchan;@@ -2032,7 +2027,6 @@ static int atmel_xdmac_resume(struct device *dev) } return 0; } -#endif /* CONFIG_PM_SLEEP */ static int at_xdmac_probe(struct platform_device *pdev) {
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel