Re: [PATCH v7 2/7] i2c: mediatek: Reset the handshake signal between i2c and dma
From: Kewei Xu <hidden>
Date: 2021-10-08 06:19:33
Also in:
linux-devicetree, linux-i2c, linux-mediatek, lkml
On Sat, 2021-10-02 at 08:30 +0200, Wolfram Sang wrote:
quoted
+#define I2C_CLR_DEBUGCTR 0x0000Hmm, I don't think that a macro to clear a register helps readability...quoted
+ mtk_i2c_writew(i2c, I2C_CLR_DEBUGCTR, OFFSET_DEBUGCTRL);.. + mtk_i2c_writew(i2c, 0, OFFSET_DEBUGCTRL); looks good to me. Anyhow, it is not a big issue. Let me know if you want to change it or keep it.
OK, I will use 0x00 instead of macro on V8 version,Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel