Re: [PATCH v7 15/15] KVM: arm64: selftests: arch_timer: Support vCPU migration

On Thu, Sep 30, 2021 at 2:41 AM Zenghui Yu [off-list ref] wrote:

On 2021/9/15 6:31, Raghavendra Rao Ananta wrote:

quoted

 static void test_run(struct kvm_vm *vm)
 {
      int i, ret;
+     pthread_t pt_vcpu_migration;
+
+     pthread_mutex_init(&vcpu_done_map_lock, NULL);
+     vcpu_done_map = bitmap_alloc(test_args.nr_vcpus);

This one fails to build.

aarch64/arch_timer.c: In function 'test_run':
aarch64/arch_timer.c:321:18: warning: implicit declaration of function
'bitmap_alloc'; did you mean 'bitmap_zalloc'?
[-Wimplicit-function-declaration]
   vcpu_done_map = bitmap_alloc(test_args.nr_vcpus);
                   ^~~~~~~~~~~~
                   bitmap_zalloc
aarch64/arch_timer.c:321:16: warning: assignment makes pointer from
integer without a cast [-Wint-conversion]
   vcpu_done_map = bitmap_alloc(test_args.nr_vcpus);
                 ^

bitmap_alloc() is defined as an inline function in
tools/include/linux/bitmap.h (since 4.8), which is included as a part
of this patch. Do you mind double-checking if you have it in the
header file?
Also, the function is referenced by other tests such as
dirty_log_[perf_]]test.c. Do you see the same warnings when you
compile them too?

Regards,
Raghavendra

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel