RE: [PATCH v2 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE

Hi,

-----Original Message-----
From: Michael Tretter <m.tretter@pengutronix.de>
Sent: 25 August 2021 08:33 PM
To: linux-arm-kernel@lists.infradead.org
Cc: Michal Simek <redacted>; Rajan Vaja <redacted>; Jolly
Shah [off-list ref]; m.tretter@pengutronix.de
Subject: [PATCH v2 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE

Hi,

This is v2 of the series to cleanup and fix the zynqmp_pm_domains driver [0].

Patch 1 of this series fixes the ZynqMP PMU FW power management
initialization, which was done by the wrong driver. PM_INIT_FINALIZE must be
called from the zynqmp_pm_domains driver, which handles power domains, instead
of the zynmp_power driver, which is responsible for suspend and shutdown. As a
side effect, PM_INIT_FINALIZE powers down all devices that have not been
requested, which might lead to misbehaving devices. Calling it from the
sync_state callback ensures that all consumers have probed and are able to
handle power management themselves.

Patches 2 to 4 are various cleanup patches to improve the readability and
debugging experience of the zynqmp_pm_domains driver.

Michael

[0] https://lore.kernel.org/linux-arm-kernel/20210317160410.2097178-1-
m.tretter@pengutronix.de/

Changelog:

v2:

- move PM_INIT_FINALIZE to sync_state callback

Michael Tretter (4):
  soc: xilinx: move PM_INIT_FINALIZE to zynqmp_pm_domains driver
  soc: xilinx: cleanup debug and error messages
  soc: xilinx: use a properly named field instead of flags
  soc: xilinx: add a to_zynqmp_pm_domain macro

 drivers/soc/xilinx/zynqmp_pm_domains.c | 91 +++++++++++++++-----------
 drivers/soc/xilinx/zynqmp_power.c      |  1 -
 2 files changed, 51 insertions(+), 41 deletions(-)

--
2.30.2

Acked-by: Rajan Vaja <redacted>

Thanks,
Rajan


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel