Thread (83 messages) 83 messages, 14 authors, 2021-10-08

Re: [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended

From: Will McVicker <hidden>
Date: 2021-09-29 20:01:52
Also in: linux-clk, linux-gpio, linux-rtc, linux-samsung-soc, lkml

On Tue, Sep 28, 2021 at 8:42 PM John Stultz [off-list ref] wrote:
On Tue, Sep 28, 2021 at 4:56 PM Will McVicker [off-list ref] wrote:
quoted
This allows modules to access the value of timekeeping_suspended without
giving them write access to the variable.
It's important to cover "the why" not "the what" in these commit
messages, so you might add a note as to what code will be the user of
this (the samsung/clk-pll.c code changed later in this series).

thanks
-john
Thanks John for the tip. I will try to be better at that in the followup.

For this specific patch, I am adding this new API because the Samsung
PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the
variable 'timekeeping_suspended' to detect timeouts before the
clocksource is initialized or timekeeping itself is suspended. My
patch series aims to modularize the Samsung PLL driver. So to keep the
driver's functionality intact, I need to add this additional API.

--Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help