Re: [PATCH v3] arm64: dts: marvell: add Globalscale MOCHAbin

On Tue, Sep 28, 2021 at 5:48 PM Pali Rohár [off-list ref] wrote:

On Thursday 23 September 2021 20:18:30 Robert Marko wrote:

quoted

+/* SPI-NOR */
+&cp0_spi1{
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&cp0_spi1_pins>;
+
+     spi-flash@0 {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             compatible = "jedec,spi-nor";
+             reg = <0>;
+             spi-max-frequency = <20000000>;
+
+             partitions {
+                     compatible = "fixed-partitions";
+                     #address-cells = <1>;
+                     #size-cells = <1>;
+
+                     partition@0 {
+                             label = "u-boot";
+                             reg = <0x0 0x3e0000>;

For sure U-Boot cannot start at offset zero as this is 64-bit ARM board
which uses at least TF-A firmware, which loads U-Boot.

Also on these mvebu SoCs is executed prior TF-A firmware custom Marvell
initialization code responsible for DDR training.

So on offset zero you cannot flash U-Boot, otherwise board would not be
bootable.

So I would suggest to either define correct offset at which U-Boot
starts or rename this whole partition to something generic, e.g. with
label "firmware". To not expose that on zero offset is stored U-Boot.

Due to how big is this partition I guess it contains concatenation of
various firmware and bootloader parts.

You are correct, its the mv-ddr + TF-A + U-boot in that partition, its just a
matter of habit calling it "u-boot".
I will rename to "firmware" which is much more appropriate.

Regards,
Robert

quoted

+                             read-only;
+                     };
+
+                     partition@3e0000 {
+                             label = "hw-info";
+                             reg = <0x3e0000 0x10000>;
+                             read-only;
+                     };
+
+                     partition@3f0000 {
+                             label = "u-boot-env";
+                             reg = <0x3f0000 0x10000>;
+                     };
+             };
+     };
+};

-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel