Re: [PATCH v2 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper... | linux-arm-kernel | Ratatoskr

[PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
[PATCH v2 2/9] iio: adc: imx7d_adc: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
[PATCH v2 3/9] iio: adc: lpc18xx_adc: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
[PATCH v2 4/9] iio: adc: max1118: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
[PATCH v2 5/9] iio: adc: max1241: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
[PATCH v2 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
[PATCH v2 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
Re: [PATCH v2 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() · Linus Walleij <hidden> · 2021-09-28
[PATCH v2 8/9] iio: adc: rockchip_saradc: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
[PATCH v2 9/9] iio: adc: ti-ads7950: Make use of the helper function dev_err_probe() · Cai Huoqing <hidden> · 2021-09-28
Re: [PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() · Linus Walleij <hidden> · 2021-09-28

Re: [PATCH v2 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()

From: Linus Walleij <hidden>
Date: 2021-09-28 13:50:55
Also in: linux-amlogic, linux-arm-msm, linux-iio, linux-rockchip, lkml

On Tue, Sep 28, 2021 at 3:37 AM Cai Huoqing [off-list ref] wrote:

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <redacted>

(...)

-               return -ENXIO;
+               return -ENODEV;

Why?

I think it's the right change, but should be in the changelog.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel