Re: [PATCH 02/10] i2c: pasemi: Use io{read,write}32
From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-09-27 07:39:52
Also in:
linux-i2c, linuxppc-dev, lkml
On Sun, Sep 26, 2021 at 12:00 PM Sven Peter [off-list ref] wrote:
In preparation for splitting this driver up into a platform_driver
and a pci_driver, replace outl/inl usage with ioport_map and
ioread32/iowrite32.
Signed-off-by: Sven Peter <redacted>
+ smbus->ioaddr = ioport_map(smbus->base, smbus->size);
+ if (!smbus->ioaddr) {
+ error = -EBUSY;
+ goto out_release_region;
+ }
While this works, I would suggest using the more regular pci_iomap()
or pcim_iomap() helper to turn the port number into an __iomem token.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel