Re: [PATCH V3 2/2] dt-bindings: remoteproc: k3-dsp: Remove board-specific compatible from DT example
From: Nishanth Menon <nm@ti.com>
Date: 2021-09-25 14:52:52
Also in:
linux-devicetree, linux-remoteproc, lkml
On 12:54-20210924, Suman Anna wrote:
Hi Sinthu, On 9/24/21 12:25 PM, Suman Anna wrote:quoted
On 9/24/21 11:29 AM, Nishanth Menon wrote:quoted
On 11:10-20210924, Suman Anna wrote:quoted
Hi Sinthu, On 9/17/21 4:54 AM, Sinthu Raja wrote:quoted
From: Sinthu Raja <redacted> The example includes a board-specific compatible property, this is wrong as the example should be board agnostic and gets in the way of additions for newer platforms. Replace the same with a generic soc node.What board specific property? This description looks wrong.Can you please repost dropping the Fixes line, and modifying the patch description as follows: dt-bindings: remoteproc: k3-dsp: Cleanup SoC compatible from DT example The K3 DSP binding example used the root-node with a SoC compatible property originally to address the dt_binding_check warnings resulting from using a value of 2 for #address-cells and #size-cells as per most common usage on K3 SoCs. Clean this up and replace it with a generic soc node to keep it agnostic of the SoC or board compatibles that are outside the scope of this binding.
This looks good to me as well. Thanks. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel