Re: [PATCH] media: imx: Fix rounding
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2021-09-24 11:46:39
Also in:
linux-media, linux-staging, lkml, phone-devel
Hi Dorota, On Fri, Sep 24, 2021 at 12:06:31PM +0200, Dorota Czaplejewicz wrote:
Change rounding to the minimal burst size from 2^n to n. This fixes images with sizes that are a multiple of 8 pixels.
Could you elaborate on what is currently wrong with images that are a multiple of 8 pixels wide? Or are you rather trying to add support for images that are not a multiple of 8 pixels wide?
quoted hunk ↗ jump to hunk
See section 13.7.6.13 CSI Image Parameter Register of the i.MX 8M Quad Applications Processors Reference Manual. Fixes: 451a7b7815d0b ("media: imx: lift CSI and PRP ENC/VF width alignment restriction") Signed-off-by: Dorota Czaplejewicz <redacted> --- Hi, I tested this patch on the Librem 5 with the main camera. --Dorota drivers/staging/media/imx/imx-media-utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c index 5128915a5d6f..a2d8fab32a39 100644 --- a/drivers/staging/media/imx/imx-media-utils.c +++ b/drivers/staging/media/imx/imx-media-utils.c@@ -545,13 +545,13 @@ int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, } /* Round up width for minimum burst size */ - width = round_up(mbus->width, 8); + width = round_up(mbus->width, 3);
That is not a valid use of the round_up() macro anymore. The second parameter must be a power of 2. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel