-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Saturday, September 18, 2021 3:49 AM
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: dl-linux-imx <redacted>; linux-phy@lists.infradead.org;
l.stach@pengutronix.de; linux-arm-kernel@lists.infradead.org;
kernel@pengutronix.de; kishon@ti.com; linux-kernel@vger.kernel.org;
vkoul@kernel.org; shawnguo@kernel.org; devicetree@vger.kernel.org;
galak@kernel.crashing.org
Subject: Re: [PATCH 2/4] dt-bindings: phy: add imx8 pcie phy driver support

On Fri, 17 Sep 2021 10:31:01 +0800, Richard Zhu wrote:

quoted

Add dt-binding for the standalone i.MX8 PCIe PHY driver.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
 .../bindings/phy/fsl,imx8-pcie-phy.yaml       | 66 +++++++++++++++++++
 1 file changed, 66 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

Thanks for your comments. The errors are fixed by adding "$ref" below.
       Refer include/dt-bindings/phy/phy-imx8-pcie.h for the constants
       to be used.
+    $ref: /schemas/types.yaml#/definitions/uint32
     enum: [ 0, 1, 2 ]

Best Regards
Richard Zhu

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fsl,i
mx8-pcie-phy.yaml: properties:fsl,refclk-pad-mode: 'oneOf' conditional failed,
one must be fixed:
	'type' is a required property
		hint: A vendor boolean property can use "type: boolean"
	Additional properties are not allowed ('enum' was unexpected)
		hint: A vendor boolean property can use "type: boolean"
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ph
y/fsl,imx8-pcie-phy.yaml: properties:fsl,refclk-pad-mode: 'oneOf' conditional
failed, one must be fixed:
		'$ref' is a required property
		'allOf' is a required property
		hint: A vendor property needs a $ref to types.yaml
		from schema $id:
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree
.org%2Fmeta-schemas%2Fvendor-props.yaml%23&data=04%7C01%7Chon
gxing.zhu%40nxp.com%7Cfacb5eafa5eb4fe72a1908d97a1430c0%7C686ea1d3
bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637675049421428781%7CUnkno
wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
WwiLCJXVCI6Mn0%3D%7C1000&sdata=lOkPSEyYhyhHPHQBi916FgdPeqK
GWi1yCC1KyhlsUCU%3D&reserved=0
	0 is not of type 'string'
		hint: A vendor string property with exact values has an implicit type
	1 is not of type 'string'
		hint: A vendor string property with exact values has an implicit type
	2 is not of type 'string'
		hint: A vendor string property with exact values has an implicit type
	hint: Vendor specific properties must have a type and description unless
they have a defined, common suffix.
	from schema $id:
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree
.org%2Fmeta-schemas%2Fvendor-props.yaml%23&data=04%7C01%7Chon
gxing.zhu%40nxp.com%7Cfacb5eafa5eb4fe72a1908d97a1430c0%7C686ea1d3
bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637675049421428781%7CUnkno
wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
WwiLCJXVCI6Mn0%3D%7C1000&sdata=lOkPSEyYhyhHPHQBi916FgdPeqK
GWi1yCC1KyhlsUCU%3D&reserved=0
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fsl,i
mx8-pcie-phy.yaml: ignoring, error in schema: properties: fsl,refclk-pad-mode
warning: no schema found in
file: ./Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.example.dt.yaml:0:0:
/example-0/pcie-phy@32f00000: failed to match any schema with compatible:
['fsl,imx8mm-pcie-phy']

doc reference errors (make refcheckdocs):

See
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwor
k.ozlabs.org%2Fpatch%2F1529140&data=04%7C01%7Chongxing.zhu%40
nxp.com%7Cfacb5eafa5eb4fe72a1908d97a1430c0%7C686ea1d3bc2b4c6fa92c
d99c5c301635%7C0%7C0%7C637675049421428781%7CUnknown%7CTWFpb
GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
Mn0%3D%7C1000&sdata=qePjUlHV6abE0GeKxqqoddS8%2Bc28wRGOoLB
NyDPpDc8%3D&reserved=0

This check can fail if there are any dependencies. The base for a patch series is
generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s),
then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel