Thread (9 messages) 9 messages, 4 authors, 2022-02-18

Re: [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens

From: Chanwoo Choi <hidden>
Date: 2021-09-22 07:55:44
Also in: linux-devicetree, linux-pm, linux-samsung-soc, lkml

Hi Krzysztof,

On 21. 9. 20. 오후 4:17, Krzysztof Kozlowski wrote:
quoted hunk ↗ jump to hunk
Devicetree naming convention requires device node names to use hyphens
instead of underscore, so Exynos5422 devfreq event name
"ppmu-event3-dmc0_0" should be "ppmu-event3-dmc0-0".  Newly introduced
dtschema enforces this, however the driver still expects old name with
an underscore.

Add new events for Exynos5422 while still accepting old name for
backwards compatibility.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
  drivers/devfreq/event/exynos-ppmu.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 17ed980d9099..541bd13ab61d 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -94,11 +94,16 @@ static struct __exynos_ppmu_events {
  	PPMU_EVENT(d1-general),
  	PPMU_EVENT(d1-rt),
  
-	/* For Exynos5422 SoC */
+	/* For Exynos5422 SoC, deprecated (backwards compatible) */
  	PPMU_EVENT(dmc0_0),
  	PPMU_EVENT(dmc0_1),
  	PPMU_EVENT(dmc1_0),
  	PPMU_EVENT(dmc1_1),
+	/* For Exynos5422 SoC */
+	PPMU_EVENT(dmc0-0),
+	PPMU_EVENT(dmc0-1),
+	PPMU_EVENT(dmc1-0),
+	PPMU_EVENT(dmc1-1),
  };
  
  static int __exynos_ppmu_find_ppmu_id(const char *edev_name)
Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help