Thread (6 messages) flat view 6 messages, 4 authors, 2021-10-11

Re: [PATCH linux-next v2] arm64: PCI: Introduce pcibios_free_irq() helper function

From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2021-09-21 13:47:28
Also in: lkml

On Thu, Aug 26, 2021 at 02:04:06PM +0800, Yajun Deng wrote:
quoted hunk ↗ jump to hunk
pcibios_alloc_irq() will be called in pci_device_probe(), but there
hasn't pcibios_free_irq() in arm64 architecture correspond it.
pcibios_free_irq() is an empty weak function in drivers/pci/pci-driver.c.
So add pcibios_free_irq() for correspond it. This will be called
in pci_device_remove().

====================
v2: remove the change in pcibios_alloc_irq(), and modify the commit log.
====================

Signed-off-by: Yajun Deng <redacted>
---
 arch/arm64/kernel/pci.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
index 2276689b5411..6ffd92126f65 100644
--- a/arch/arm64/kernel/pci.c
+++ b/arch/arm64/kernel/pci.c
@@ -29,6 +29,13 @@ int pcibios_alloc_irq(struct pci_dev *dev)
 
 	return 0;
 }
+
+void pcibios_free_irq(struct pci_dev *dev)
+{
+	if (!acpi_disabled)
+		acpi_pci_irq_disable(dev);
+}
For symmetry with the alloc path, this looks fine but I'd like Lorenzo
to confirm.

The other questions, what does it fix and do we need a cc stable?

Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help