Re: [PATCH V4 1/6] remoteproc: elf_loader: fix loading segment when is_iomem true
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Date: 2021-09-20 16:24:06
Also in:
linux-remoteproc, lkml
On Fri, Sep 10, 2021 at 05:06:16PM +0800, Peng Fan (OSS) wrote:
From: Peng Fan <peng.fan@nxp.com> It seems luckliy work on i.MX platform, but it is wrong. Need use memcpy_toio, not memcpy_fromio.
Lucky or not I just can't understand how this worked in the first place.
Fixes: 40df0a91b2a52 ("remoteproc: add is_iomem to da_to_va")SHA tag should be 12 characters.
Tested-by: Dong Aisheng <aisheng.dong@nxp.com> (i.MX8MQ) Reported-by: kernel test robot <redacted> Reported-by: Dong Aisheng <aisheng.dong@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com>
I will add a CC:stable, fix the title, fix the SHA and pick this patch.
quoted hunk ↗ jump to hunk
--- drivers/remoteproc/remoteproc_elf_loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c index 469c52e62faff..44e7f9308f4bc 100644 --- a/drivers/remoteproc/remoteproc_elf_loader.c +++ b/drivers/remoteproc/remoteproc_elf_loader.c@@ -220,7 +220,7 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw) /* put the segment where the remote processor expects it */ if (filesz) { if (is_iomem) - memcpy_fromio(ptr, (void __iomem *)(elf_data + offset), filesz); + memcpy_toio((void __iomem *)ptr, elf_data + offset, filesz); else memcpy(ptr, elf_data + offset, filesz); }-- 2.25.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel