Re: [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module!
From: Alim Akhtar <hidden>
Date: 2021-09-19 17:32:56
Also in:
linux-samsung-soc, lkml
Hello Krzysztof On Sun, Sep 19, 2021 at 6:28 PM Krzysztof Kozlowski [off-list ref] wrote:
Hi, Changes since v1 ================ 1. Drop patch 1/2 - exporting soc_device_to_device 2. Add new patches: 1/3 and 3/3. Question ======== A question - what is the convention for naming modules: underscores '_' or hyphens '-'? The C-unit file already uses a hyphen "exynos-chipid.c", so I could create a module named: 1. exynos_chipid 2. soc-exynos-chipid 3. exynos-chip-id The Linux device name is "exynos-chipid". Best regards, Krzysztof Krzysztof Kozlowski (3): soc: samsung: exynos-chipid: avoid soc_device_to_device() soc: samsung: exynos-chipid: convert to a module soc: samsung: exynos-chipid: do not enforce built-in arch/arm/mach-exynos/Kconfig | 1 - drivers/soc/samsung/Kconfig | 4 +++- drivers/soc/samsung/Makefile | 3 ++- drivers/soc/samsung/exynos-chipid.c | 14 +++++++++++--- drivers/soc/samsung/exynos5422-asv.c | 1 + 5 files changed, 17 insertions(+), 6 deletions(-)
Thanks for the patches. For this series Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Also tested on exynos7 based platform, so Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
-- 2.30.2
-- Regards, Alim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel