Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Date: 2021-09-17 23:49:15
Also in:
linux-pci, lkml
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Date: 2021-09-17 23:49:15
Also in:
linux-pci, lkml
Hi Marc, Thank you for your comment. On 2021/09/17 22:54, Marc Zyngier wrote:
On Thu, 16 Sep 2021 12:30:52 +0100, Kunihiko Hayashi [off-list ref] wrote:quoted
Gentle ping, are there any comments about this series? Thank you, On 2021/08/30 11:22, Kunihiko Hayashi wrote:quoted
This series includes some fixes to INTx masking/unmasking for UniPhier PCIe host controller driver. - Remove unnecessary bit clears to INTX mask field - Remove unnecessary irq_ack() function because write access to status field doesn't work - Add lock into callback functions to avoid race condition Kunihiko Hayashi (2): PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack function PCI: uniphier: Serialize INTx masking/unmasking drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-)Patches look OK, although I would personally squash them into a single one (INTx masking never really worked before that). FWIW:
Surely applying only the first patch leaves the issue with the second one. I'll squash them in v3. Thank you,
Acked-by: Marc Zyngier <maz@kernel.org> N,
--- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel