Re: [PATCH 2/4] gpio/rockchip: fix get_direction value handling
From: Linus Walleij <hidden>
Date: 2021-09-17 23:30:41
Also in:
linux-gpio, linux-rockchip, lkml
On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner [off-list ref] wrote:
The function uses the newly introduced rockchip_gpio_readl_bit()
which directly returns the actual value of the requeste bit.
So using the existing bit-wise check for the bit inside the value
will always return 0.
Fix this by dropping the bit manipulation on the result.
Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>Reviewed-by: Linus Walleij <redacted> Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel