Re: [PATCH v2] spi: atmel: Fix PDC transfer setup bug
flat view
From: <hidden>
Date: 2021-09-17 16:08:31
Also in:
linux-spi, lkml
On 9/17/21 12:46 AM, Ville Baillie wrote:
[Some people who received this message don't often get email from villeb@bytesnap.co.uk. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.] EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe From 7f796c2004407f848f9ed97f406e24b9eadd74be Mon Sep 17 00:00:00 2001 From: Ville Baillie <redacted> Date: Thu, 16 Sep 2021 14:16:46 +0000 Subject: [PATCH v2] spi: atmel: Fix PDC transfer setup bug Commit 5fa5e6dec762 ("spi: atmel: Switch to transfer_one transfer method") refactored the code and changed a conditional causing atmel_spi_dma_map_xfer to never be called in PDC mode. This causes the driver to silently fail. This patch changes the conditional to match the behaviour of the previous commit before the refactor. Signed-off-by: Ville Baillie <redacted>
Reviewed-by: Dan Sneddon <redacted>
quoted hunk ↗ jump to hunk
--- drivers/spi/spi-atmel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 788dcdf25f00..f872cf196c2f 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c@@ -1301,7 +1301,7 @@ static int atmel_spi_one_transfer(struct spi_master *master, * DMA map early, for performance (empties dcache ASAP) and * better fault reporting. */ - if ((!master->cur_msg_mapped) + if ((!master->cur_msg->is_dma_mapped) && as->use_pdc) { if (atmel_spi_dma_map_xfer(as, xfer) < 0) return -ENOMEM;@@ -1381,7 +1381,7 @@ static int atmel_spi_one_transfer(struct spi_master *master, } } - if (!master->cur_msg_mapped + if (!master->cur_msg->is_dma_mapped && as->use_pdc) atmel_spi_dma_unmap_xfer(master, xfer); --2.17.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel