Re: [PATCH] i2c: s3c2410: Delete unneeded variable: "ret"
flat view
From: Krzysztof Kozlowski <hidden>
Date: 2021-09-16 10:52:44
Also in:
linux-i2c, linux-samsung-soc, lkml
On 16/09/2021 12:37, Xiang wangx wrote:
quoted hunk ↗ jump to hunk
variable: "ret" defined but not used in function "i2c_s3c_irq_nextbyte" Signed-off-by: Xiang wangx <redacted> --- drivers/i2c/busses/i2c-s3c2410.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index b49a1b170bb2..6df85b23156c 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c@@ -385,7 +385,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) { unsigned long tmp; unsigned char byte; - int ret = 0; switch (i2c->state) {@@ -548,7 +547,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) tmp &= ~S3C2410_IICCON_IRQPEND; writel(tmp, i2c->regs + S3C2410_IICCON); out: - return ret; + return 0;
Change is okay but I would go step further - made the function return void(). None of the callers check for return so no functionality is lost. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel