Re: [PATCH v2] arm64: dts: imx8mq-kontron-pitx-imx8m: remove vqmmc-supply node
flat view
From: Lucas Stach <l.stach@pengutronix.de>
Date: 2021-09-14 08:20:29
Also in:
linux-devicetree, lkml
Am Dienstag, dem 14.09.2021 um 09:26 +0200 schrieb Heiko Thiery:
The sw4 output (V_1V8_S0 voltage) from the PMIC is the main supply for the 1V8 power domain. It is not only used as supply for the eMMC. So this voltage can not be changed and is not allowed to switched off. Therefore we do not want to provide this regulator to the SDHC driver to control this voltage.
This specific requirement should not be solved by removing the regulator connection from the SDHCI node, but instead by constraining the regulator voltage range to a fixed 3.3V and marking the regulator as always-on to reflect the hardware requirements in the DT. Also if your eMMC vqmmc is a fixed 3.3V, I don't think you need the faster pinctrl states, as you can't use the faster pin states anyways, as they require a 1.8V signaling voltage. Regards, Lucas
quoted hunk ↗ jump to hunk
Fixes: 5dbadc848259 ("arm64: dts: fsl: add support for Kontron pitx-imx8m board") Signed-off-by: Heiko Thiery <redacted> --- v2: - slightly reword the commit message (thanks Michael) - add Fixes tag (thanks Fabio) arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts index f593e4ff62e1..436d98135ba9 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts@@ -348,7 +348,6 @@ &usdhc1 { pinctrl-0 = <&pinctrl_usdhc1>; pinctrl-1 = <&pinctrl_usdhc1_100mhz>; pinctrl-2 = <&pinctrl_usdhc1_200mhz>; - vqmmc-supply = <&sw4_reg>; bus-width = <8>; non-removable; no-sd;
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel