Re: [PATCH] arm64/kernel: remove duplicate include in process.c
flat view
From: Mark Rutland <mark.rutland@arm.com>
Date: 2021-09-13 12:09:21
Also in:
lkml
On Wed, Sep 01, 2021 at 06:11:26PM -0700, cgel.zte@gmail.com wrote:
quoted hunk ↗ jump to hunk
From: Lv Ruyi <redacted> Remove all but the first include of linux/sched.h from process.c Reported-by: Zeal Robot <redacted> Signed-off-by: Lv Ruyi <redacted> --- arch/arm64/kernel/process.c | 1 - 1 file changed, 1 deletion(-)diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 19100fe8f7e4..1a1213cca173 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c@@ -18,7 +18,6 @@ #include <linux/mman.h> #include <linux/mm.h> #include <linux/nospec.h> -#include <linux/sched.h> #include <linux/stddef.h> #include <linux/sysctl.h> #include <linux/unistd.h>
For the benefit of other reviewers, while it's not obvious from the patch context, arlier in the includes (which aren't currently sorted), there's a block with: | #include <linux/sched.h> | #include <linux/sched/debug.h> | #include <linux/sched/task.h> | #include <linux/sched/task_stack.h> ... and so this patch looks good to me: Acked-by: Mark Rutland <mark.rutland@arm.com> IMO it would be nice to sort the includes if that's not too churny (but that should be a separate patch). Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel